Skip to content

Custom Scalars input serialization in variables#253

Merged
leszekhanusz merged 4 commits intographql-python:masterfrom
leszekhanusz:feature_custom_types
Nov 19, 2021
Merged

Custom Scalars input serialization in variables#253
leszekhanusz merged 4 commits intographql-python:masterfrom
leszekhanusz:feature_custom_types

Conversation

@leszekhanusz
Copy link
Copy Markdown
Collaborator

@leszekhanusz leszekhanusz commented Nov 13, 2021

New feature which implements Custom Scalars serialization in variable_values.

For this feature to work:

  • a schema is needed
  • the scalars implementation should be added as a GraphQLScalarType in the schema
  • the execute or subscribe methods (sync or async) should be called with serialize_variables=True

@leszekhanusz
Implementation of serialization of variable values
97cd612
@leszekhanusz
Skip datetime tests on Python 3.6
2b3db14
@leszekhanusz
Add update_schema_scalars function
c251a2f 
This function allows us to update a schema from a file or from introspection
with custom scalars implementations
@leszekhanusz
Adding documentation
1047885
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 13, 2021 •
edited by codecov Bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d5e3e6d) to head (1047885).
⚠️ Report is 207 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #253   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        19    +3     
  Lines         1335      1404   +69     
=========================================
+ Hits          1335      1404   +69

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was linked to issues Nov 13, 2021
Feature request: support for custom json serialization #216
Closed
DSL - Datetime argument serialization failing #209
Closed
@leszekhanusz leszekhanusz requested a review from Cito November 13, 2021 13:11
@leszekhanusz leszekhanusz merged commit 37f1917 into graphql-python:master Nov 19, 2021
@leszekhanusz leszekhanusz mentioned this pull request Nov 19, 2021
Merged
@leszekhanusz leszekhanusz deleted the feature_custom_types branch March 12, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cito Cito Awaiting requested review from Cito

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: support for custom json serialization DSL - Datetime argument serialization failing

2 participants

@leszekhanusz @codecov-commenter